Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: checking for deref flag in file_name #937

Merged
merged 2 commits into from
Apr 22, 2024
Merged

Conversation

MartinFillon
Copy link
Contributor

@MartinFillon MartinFillon commented Apr 18, 2024

As per Vosjedev mentionned on #932 dereference (-X) was ignored on latest eza version however it was used for file-names. This was due to the usage of the function with_link_paths that forced a link printing, whereas the deref flag prevent it.

This also adds some debug printing.
closes #932

@MartinFillon MartinFillon requested a review from PThorpe92 as a code owner April 18, 2024 07:19
@MartinFillon MartinFillon added errors Something isn't working errors › runtime error Arguments Relates to arguments parsing/modifying/Adding labels Apr 18, 2024
@MartinFillon MartinFillon force-pushed the investigate-dereference branch from 866a9e0 to 04f142c Compare April 18, 2024 09:49
As per Vosjedev mentionned on #932 dereference (`-X`) was ignored on
latest eza version however it was used for file-names.
This was due to the usage of the function `with_link_paths` that forced
a link printing, whereas the deref flag prevent it.

This also adds some debug printing.
@MartinFillon MartinFillon force-pushed the investigate-dereference branch from 04f142c to 9bd0912 Compare April 20, 2024 19:23
@MartinFillon MartinFillon merged commit 8afb5cc into main Apr 22, 2024
19 checks passed
@cafkafk cafkafk deleted the investigate-dereference branch April 28, 2024 14:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Arguments Relates to arguments parsing/modifying/Adding errors › runtime error errors Something isn't working
Projects
Status: ✅ Done
Development

Successfully merging this pull request may close these issues.

bug: -X/--dereference was broken and no longer working for filenames
2 participants